London | 26-ITP-Jan | Oussama Mouggal | Sprint 2 | Data-Groups#990
Open
Oussama-Mouggal wants to merge 6 commits intoCodeYourFuture:mainfrom
Open
London | 26-ITP-Jan | Oussama Mouggal | Sprint 2 | Data-Groups#990Oussama-Mouggal wants to merge 6 commits intoCodeYourFuture:mainfrom
Oussama-Mouggal wants to merge 6 commits intoCodeYourFuture:mainfrom
Conversation
…ns with corresponding tests
…lateMode into smaller functions and add tests for totalTill function
Oussama-Mouggal
added
the
Needs Review
oyagbileoluwaseun
added
Review in progress
| console.log(`${recipe.title} serves ${recipe.serves} | ||
| ingredients: | ||
| ${recipe}`); | ||
| console.log(`${recipe.title} serves ${recipe.serves}`); |
There was a problem hiding this comment.
This is good, you can also look for a way to stringify the whole object. well done.
| @@ -1,6 +1,22 @@ | |||
| const createLookup = require("./lookup.js"); | |||
|
|
|||
| test.todo("creates a country currency code lookup for multiple codes"); | |||
There was a problem hiding this comment.
This is also good. I also recommend that you look into adding input validation, if the list is not iterable, this can break.
| } | ||
|
|
||
| return `£${total / 100}`; | ||
| return `£${(total / 100).toFixed(2)}`; |
oyagbileoluwaseun
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
I fixed the Sprint-2 debug exercises, completed and tested all implement functions